Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(code-connect): connect additional components #16971

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Jul 16, 2024

Changelog

New

  • Update to latest code connect version
  • Connect following components
    • ComposedModal
    • DatePicker
    • Dropdown
    • FileUploader
    • Form
    • Notification
    • Popover
    • ProgressIndicator
    • Slider
    • TextArea
    • TextInput
    • TimePicker
    • Toggletip
    • Tooltip
    • Menu, MenuItem

@alisonjoseph alisonjoseph changed the title Code connect additional components alison feat(code-connect): connect additional components Jul 16, 2024
@alisonjoseph alisonjoseph marked this pull request as ready for review July 16, 2024 19:01
@alisonjoseph alisonjoseph requested a review from a team as a code owner July 16, 2024 19:01
Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 543fe10
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6696c2f4bc000d00083df552
😎 Deploy Preview https://deploy-preview-16971--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 543fe10
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6696c2f4d5bfba0008ee2592
😎 Deploy Preview https://deploy-preview-16971--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bd5a205
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/669ed493c07f2c000757f077
😎 Deploy Preview https://deploy-preview-16971--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit bd5a205
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/669ed49347a6b10008ef8aac
😎 Deploy Preview https://deploy-preview-16971--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loooking good! just a few comments i wasn't sure about

@alisonjoseph
Copy link
Member Author

alisonjoseph commented Jul 17, 2024

@ariellalgilmore thanks for reviewing! I just removed TimePicker from this PR, its not finished yet and cleanup the other two files. 😅

Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome LGTM!

@riddhybansal riddhybansal added this pull request to the merge queue Jul 23, 2024
Merged via the queue into carbon-design-system:main with commit 351525d Jul 23, 2024
22 checks passed
@alisonjoseph alisonjoseph deleted the code-connect-additional-components-alison branch July 23, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants