Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: filterItems prop in FilterableMultiSelect should be optional #16993

Open
2 tasks done
guidari opened this issue Jul 18, 2024 · 3 comments
Open
2 tasks done

[Bug]: filterItems prop in FilterableMultiSelect should be optional #16993

guidari opened this issue Jul 18, 2024 · 3 comments

Comments

@guidari
Copy link
Contributor

guidari commented Jul 18, 2024

Package

@carbon/react

Browser

No response

Package version

v11.62.0

React version

18.02

Description

The option filterItems should be optional and also added to the FilterableMultiSelect.propTypes.

It should show the props in the Overview page.
Screenshot 2024-07-18 at 10 49 55

Reproduction/example

https://react.carbondesignsystem.com/?path=/docs/components-multiselect--overview

Steps to reproduce

Prop is required in typescript code

Suggested Severity

Severity 3 = User can complete task, and/or has a workaround within the user experience of a given component.

Application/PAL

No response

Code of Conduct

@jesnajoseijk
Copy link
Contributor

Hi @guidari could you assign it me so that I can work on it

@guidari guidari assigned jesnajoseijk and unassigned guidari Jul 19, 2024
@ecrvich
Copy link

ecrvich commented Sep 27, 2024

Still seeing the TS error in Carbon 1.66.0. Is anything happening with this? It's been a couple months...

Simply adding a question mark to the function name in FilterableMultiSelect.d.ts fixes the error:

image

And then add something like this to propTypes in FilterableMultiSelect.js:

  /**
   * Optional function to filter the items based on the text
   * entered by the user.
   */
  filterItems: PropTypes__default["default"].func,

@guidari
Copy link
Contributor Author

guidari commented Oct 8, 2024

Hey @ecrvich Looks like the previous assignee didn't get to the issue, so I just removed it. Feel free to open a PR if you want!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ⏱ Backlog
Development

No branches or pull requests

3 participants