Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace isEqual with react-fast-compare #17061

Closed
tay1orjones opened this issue Jul 29, 2024 · 1 comment · Fixed by #17062
Closed

Replace isEqual with react-fast-compare #17061

tay1orjones opened this issue Jul 29, 2024 · 1 comment · Fixed by #17062
Assignees
@riddhybansal
Labels
role: dev 🤖 type: infrastructure 🤖 Issues relating to devops, tech debt, etc.

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Jul 29, 2024 •
edited
Loading

In #17056 a performance fix was added for DataTable by replacing lodash isEqual with react-fast-compare. This should be done for all other instances in the codebase as it supports both React element comparison and general-purpose deep comparison.

Usages
@tay1orjones tay1orjones moved this to ⏱ Backlog in Design System Jul 29, 2024
@tay1orjones tay1orjones added role: dev 🤖 type: infrastructure 🤖 Issues relating to devops, tech debt, etc. labels Jul 29, 2024
@riddhybansal
Copy link
Contributor

Ref https://www.npmjs.com/package/react-fast-compare how react-fast-compare is much much better than lodash

@riddhybansal riddhybansal self-assigned this Jul 29, 2024
@riddhybansal riddhybansal mentioned this issue Jul 29, 2024
Merged
@riddhybansal riddhybansal moved this from ⏱ Backlog to 🚦 In Review in Design System Jul 30, 2024
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riddhybansal riddhybansal

Labels
role: dev 🤖 type: infrastructure 🤖 Issues relating to devops, tech debt, etc.
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: performance by removing lodash by react-fast-compare riddhybansal/carbon
2 participants
@tay1orjones @riddhybansal