Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Button text and icon is not aligned properly #17082

Closed
2 tasks done
amal-k-joy opened this issue Aug 1, 2024 · 0 comments · Fixed by #18076
Closed
2 tasks done

[Bug]: Button text and icon is not aligned properly #17082

amal-k-joy opened this issue Aug 1, 2024 · 0 comments · Fixed by #18076
Assignees
@emyarod
Labels
component: button role: dev 🤖 severity: 3 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@amal-k-joy
Copy link

Package

@carbon/react

Browser

No response

Package version

1.63.0-rc.0

React version

No response

Description

Icon is shifted 1 px upward. This issue was highlighted by the designer in a design review prior to the release of the component.
size="sm"
kind="ghost"

image
image

Reproduction/example

https://stackblitz.com/edit/github-cmyg5o?file=src%2FApp.jsx

Steps to reproduce

  1. Create a ghost button of size sm with an icon and text

Suggested Severity

None

Application/PAL

No response

Code of Conduct
@amal-k-joy amal-k-joy mentioned this issue Aug 1, 2024
Closed
26 tasks
@Gururajj77 Gururajj77 moved this to ⏱ Backlog in Design System Aug 1, 2024
@emyarod emyarod self-assigned this Nov 6, 2024
@emyarod emyarod mentioned this issue Nov 14, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emyarod emyarod

Labels
component: button role: dev 🤖 severity: 3 https://ibm.biz/carbon-severity type: bug 🐛
Projects
Design System
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(button): center align ghost button icons emyarod/carbon
3 participants
@emyarod @Gururajj77 @amal-k-joy