Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contained Tabs to include Layer component inside TabPanel #17224

Open
Tracked by #15803
ariellalgilmore opened this issue Aug 20, 2024 · 0 comments
Open
Tracked by #15803

Contained Tabs to include Layer component inside TabPanel #17224

ariellalgilmore opened this issue Aug 20, 2024 · 0 comments
Labels
component: tabs version: 12 Issues pertaining to a future major release of Carbon

Comments

@ariellalgilmore
Copy link
Member

ariellalgilmore commented Aug 20, 2024 •
edited
Loading

#17215
^ follow up from this PR

Currently in v11 when using Contained Tabs or Vertical Tabs an adopter must use a <Layer> inside if any field components are being used inside the TabPanel. TabPanel has no connection at the moment if the <Tab> is contained or not.

idea: Somehow TabPanel will know if it is a type of Contained Tab and automatically wrap the children in a <Layer>. We could also make a codemod that would remove any <Layer> components being used, so that it would be a seamless transisition for adopters
@ariellalgilmore ariellalgilmore mentioned this issue Aug 20, 2024
Open
@ariellalgilmore ariellalgilmore added the version: 12 Issues pertaining to a future major release of Carbon label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: tabs version: 12 Issues pertaining to a future major release of Carbon
Projects
Design System
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alisonjoseph @ariellalgilmore