-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(accessibility-checker): update to versioned
ruleArchive
#17351
test(accessibility-checker): update to versioned
ruleArchive
#17351
Conversation
versioned
rulesetversioned
ruleArchive
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as outdated.
This comment was marked as outdated.
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…149-a11y-versioned-ruleset
…149-a11y-versioned-ruleset
This has now been updated again to the latest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17351 +/- ##
==========================================
+ Coverage 84.16% 84.31% +0.15%
==========================================
Files 404 404
Lines 14350 14352 +2
Branches 4649 4621 -28
==========================================
+ Hits 12077 12101 +24
+ Misses 2111 2089 -22
Partials 162 162 ☔ View full report in Codecov by Sentry. |
…/carbon into 17149-a11y-versioned-ruleset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all LGTM! One small question and did you want to add any tests for the added props in Slider.Skeleton before we merge this?
812d029
Closes #17149
Changelog
Changed
Update accessibility-checker config to use
versioned
ruleArchive (effectively06Aug2024
29Aug2024
01Oct2024
13Nov24
as of this PR)Adds
aria_attribute_conflict
,label_name_visible
andtarget_spacing_sufficient
rules to denylist inside toHaveNoACViolations of playwright and jest configs to suppress false positive violations.These should be removed after this PR gets merged -> Issue
Added test cases for
SliderSkeleton
, movedSlider-test.js
andSliderSkeleton-test.js
to__test__
folder