Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(accessibility-checker): update to versioned ruleArchive #17351

Merged

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Sep 6, 2024

Closes #17149

Changelog

Changed

  • Update accessibility-checker config to use versioned ruleArchive (effectively 06Aug2024 29Aug2024 01Oct2024 13Nov24 as of this PR)

  • Adds aria_attribute_conflict, label_name_visible and target_spacing_sufficient rules to denylist inside toHaveNoACViolations of playwright and jest configs to suppress false positive violations.

  • These should be removed after this PR gets merged -> Issue

  • Added test cases for SliderSkeleton, moved Slider-test.js and SliderSkeleton-test.js to __test__ folder

@tay1orjones tay1orjones changed the title test(accessibility-checker): update to versioned ruleset test(accessibility-checker): update to versioned ruleArchive Sep 6, 2024
Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit c412102
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/675add59da8c91000800f25b
😎 Deploy Preview https://deploy-preview-17351--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c412102
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/675add5975fcbc000870ad4c
😎 Deploy Preview https://deploy-preview-17351--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones

This comment was marked as outdated.

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit c412102
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/675add59d5c9d30008f9766a
😎 Deploy Preview https://deploy-preview-17351--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones
Copy link
Member Author

This has now been updated again to the latest Oct 1 ruleset

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.31%. Comparing base (181f38f) to head (c412102).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...es/react/src/components/Slider/Slider.Skeleton.tsx 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17351      +/-   ##
==========================================
+ Coverage   84.16%   84.31%   +0.15%     
==========================================
  Files         404      404              
  Lines       14350    14352       +2     
  Branches     4649     4621      -28     
==========================================
+ Hits        12077    12101      +24     
+ Misses       2111     2089      -22     
  Partials      162      162              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@2nikhiltom 2nikhiltom marked this pull request as ready for review December 10, 2024 10:01
@2nikhiltom 2nikhiltom requested review from a team as code owners December 10, 2024 10:01
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all LGTM! One small question and did you want to add any tests for the added props in Slider.Skeleton before we merge this?

packages/styles/scss/components/text-area/_text-area.scss Outdated Show resolved Hide resolved
@tay1orjones tay1orjones added this pull request to the merge queue Dec 12, 2024
Merged via the queue into carbon-design-system:main with commit 812d029 Dec 12, 2024
37 checks passed
@tay1orjones tay1orjones deleted the 17149-a11y-versioned-ruleset branch December 12, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to versioned accessibility-checker config, latest ruleset
4 participants