Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: User not getting caught in ComposedModal focus trap #17918

Closed
2 tasks done
RachelGHogan opened this issue Oct 30, 2024 · 0 comments · Fixed by #17940
Closed
2 tasks done

[Bug]: User not getting caught in ComposedModal focus trap #17918

RachelGHogan opened this issue Oct 30, 2024 · 0 comments · Fixed by #17940
Assignees

Comments

@RachelGHogan
Copy link

Package

@carbon/react

Browser

Chrome

Package version

1.69.0

React version

No response

Description

If you have a ComposedModal and don't explicitly pass it an element you want focus on, you don't get automatically moved to/caught in the focus trap.

Reproduction/example

https://stackblitz.com/edit/github-xvaxt4-zt45ye?file=src%2FTearsheet.scss

Steps to reproduce

  1. Open the stackblitz linked in the reproduction/example section above
  2. Click (or tab to and press enter) on the first button with the text "launch composed modal"
  3. Press the tab key to observe that focus is still on the base page (you will be tabbing through the other buttons, as focus was not moved to the modal)

Suggested Severity

None

Application/PAL

No response

Code of Conduct

@guidari guidari self-assigned this Oct 30, 2024
@guidari guidari moved this to ⏱ Backlog in Design System Oct 30, 2024
@guidari guidari moved this from ⏱ Backlog to 🏗 In Progress in Design System Oct 31, 2024
@guidari guidari moved this from 🏗 In Progress to 🚦 In Review in Design System Oct 31, 2024
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants