Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorator 🎄 #17921

Closed
1 task done
sstrubberg opened this issue Oct 31, 2024 · 3 comments
Closed
1 task done

Decorator 🎄 #17921

sstrubberg opened this issue Oct 31, 2024 · 3 comments
Assignees
Labels
planning: umbrella Umbrella issues, surfaced in Projects views role: dev 🤖 type: enhancement 💡

Comments

@sstrubberg
Copy link
Member

sstrubberg commented Oct 31, 2024

Brief

Why are we doing this? What is this for?

Closes #17303

Allow for flexibility within components using AILabel to allow for other components such as Tooltip to be added instead of just AILabel. Example: in DataTable adding a Tooltip where AILabel is currently but without the additional AILabel gradient styles

Acceptance Criteria for each effected component

  • Change slug prop to decorator
    • This will accept any node, most commonly an AILabel, but also could be a tooltip/toggletip/etc.
  • Deprecate slug prop
  • Update classnames and add new duplicate classname selectors within components using AILabel to use the new #{$prefix}--decorator
  • Update styles
    • If a consumer is still using the AILabel component, then we want retain the AILabel styles. (ex. Datatable)
    • Add new duplicate classname selectors to the each of the components styles
      - .#{$prefix}--tile .#{$prefix}--tile--slug {
      
      +.#{$prefix}--tile .#{$prefix}--tile--slug {,
      + .#{$prefix}--tile .#{$prefix}--tile--decorator {
        // will be broken out to ensure styles from AILabel stay, but if no AILabel then no additional gradient styles
  • Create a new sub-issue/tasklist item on v12 #15803 for removing these classes as part of v12

Tasks

Preview Give feedback
  1. package: styles role: dev 🤖
    ariellalgilmore
@sstrubberg sstrubberg changed the title Decorator Decorator 🏖 Oct 31, 2024
@sstrubberg sstrubberg moved this to Next ➡ in Roadmap Oct 31, 2024
@sstrubberg sstrubberg changed the title Decorator 🏖 Decorator 🎄 Nov 1, 2024
@sstrubberg sstrubberg added type: enhancement 💡 role: dev 🤖 planning: umbrella Umbrella issues, surfaced in Projects views labels Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Thank you for submitting a feature request. Your proposal is open and will soon be triaged by the Carbon team.

If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request you or other volunteers from the community to work on this issue.

@ariellalgilmore ariellalgilmore self-assigned this Nov 5, 2024
@sstrubberg sstrubberg moved this from Next ➡ to Now 💫 in Roadmap Nov 6, 2024
@sstrubberg
Copy link
Member Author

sstrubberg commented Nov 13, 2024

We need to follow up the dev Decorator work with design guidance on the do's and don't.

@wkeese
Copy link
Contributor

wkeese commented Jan 15, 2025

Thanks for implementing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
planning: umbrella Umbrella issues, surfaced in Projects views role: dev 🤖 type: enhancement 💡
Projects
Status: Completed 🚢
Development

No branches or pull requests

3 participants