Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add a selected state to icon ghost buttons #18200

Open
1 task done
AmandaFurukawa opened this issue Dec 4, 2024 · 5 comments
Open
1 task done

[Feature Request]: Add a selected state to icon ghost buttons #18200

AmandaFurukawa opened this issue Dec 4, 2024 · 5 comments
Labels
component: button proposal: open This request has gone through triaging. We're determining whether we take this on or not. status: needs design spec type: enhancement 💡

Comments

@AmandaFurukawa
Copy link

AmandaFurukawa commented Dec 4, 2024

The problem

Currently, there is no selected state for buttons, specifically the icon ghost button. The icon ghost button is used in the text toolbar but it's not very clear what the selected state is or if there is one, but there are settings like bold, and italic which should have a selected state to show that is it on/selected.

This is not specifically for the text toolbar, these settings could also be in a side panel or tearsheet.

The solution

Add selected state to the icon ghost button, we could use the existing color tokens layer-selected-01
Image

Examples

No response

Application/PAL

Carbon for IBM Products

Business priority

Low Priority = release date is not dependent on fix or not upcoming

Available extra resources

No response

Code of Conduct

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Thank you for submitting a feature request. Your proposal is open and will soon be triaged by the Carbon team.

If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request you or other volunteers from the community to work on this issue.

@alina-jacob
Copy link
Member

Slack thread for context - Chat button's selected state

@AmandaFurukawa
Copy link
Author

That chat button selected state just looks like a focus state though or maybe I'm missing it

@sstrubberg sstrubberg moved this from Triage to Later 🧊 in Roadmap Jan 6, 2025
@sstrubberg
Copy link
Member

Possibly connected to the UI Shell workstream.

Can you elaborate more on your specific use-case?

@sstrubberg sstrubberg added the proposal: open This request has gone through triaging. We're determining whether we take this on or not. label Jan 6, 2025
@AmandaFurukawa
Copy link
Author

@sstrubberg In our product users can add charts to a dashboard, the admin flow would be creating the charts, currently they select from a dropdown menu by selecting the chart name. Having an icon associated to the chart name would be helpful for users who are not familiar with chart names vs visuals. We initially wanted to just add the chart icons to the dropdown but was told that wasn't possible with the current dropdown component so we were exploring having icon buttons and the user can select from those but we would need a selected state to show which chart is selected.

Ex concept
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: button proposal: open This request has gone through triaging. We're determining whether we take this on or not. status: needs design spec type: enhancement 💡
Projects
Status: Later 🧊
Development

No branches or pull requests

3 participants