Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Update Dropdown, Combobox & Multiselect focus states #18071

Open
1 task
Tracked by #6102
Kritvi-bhatia17 opened this issue Nov 14, 2024 · 1 comment · May be fixed by #18230
Open
1 task
Tracked by #6102

[Bug]: Update Dropdown, Combobox & Multiselect focus states #18071

Kritvi-bhatia17 opened this issue Nov 14, 2024 · 1 comment · May be fixed by #18230
Assignees
@annawen1
Labels
component: combobox component: dropdown component: filterable-multiselect component: multiselect role: dev 🤖 type: bug 🐛

Comments

@Kritvi-bhatia17
Copy link
Contributor

Kritvi-bhatia17 commented Nov 14, 2024 •
edited
Loading

Acceptance criteria

Background: Michael highlighted some differences in interaction and behavior across several Dropdown variants, including Combobox, Multiselect, Filterable Multiselect, Multiselect with Select All, and Fluid Dropdown with no default option. Specifically, a few of the focus states need adjustments. We discussed this further in the CAG call (Oct 21).
(Related figma kit issue)

Tasks

  • Update the focus state for all dropdown variants (both default & fluid) based on following interactions:
    • Mouse & 'Enter' key
    • Down arrow key

Refer to: Figma kit
@Kritvi-bhatia17 Kritvi-bhatia17 moved this to ⏱ Backlog in Design System Nov 14, 2024
@sstrubberg sstrubberg mentioned this issue Nov 20, 2024
Open
@tay1orjones
Copy link
Member

As part of this we should add keyboard nav e2e test(s) and vrt tests covering these new states

@annawen1 annawen1 moved this from ⏱ Backlog to 🏗 In Progress in Design System Dec 9, 2024
@annawen1 annawen1 linked a pull request Dec 9, 2024 that will close this issue
Open
@annawen1 annawen1 moved this from 🏗 In Progress to 🚦 In Review in Design System Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annawen1 annawen1

Labels
component: combobox component: dropdown component: filterable-multiselect component: multiselect role: dev 🤖 type: bug 🐛
Projects
Design System
Status: 🚦 In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: update focus states for Dropdown, Combobox & Multiselect annawen1/carbon
3 participants
@tay1orjones @annawen1 @Kritvi-bhatia17