Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the "Open in Stackblitz" to the rest of components #18344

Open
guidari opened this issue Jan 14, 2025 · 5 comments
Open

Adding the "Open in Stackblitz" to the rest of components #18344

guidari opened this issue Jan 14, 2025 · 5 comments
Assignees
Labels
good first issue 👋 Used by GitHub to elevate contribution opportunities planning: umbrella Umbrella issues, surfaced in Projects views role: dev 🤖 type: docs 📖

Comments

@guidari
Copy link
Contributor

guidari commented Jan 14, 2025

This PR added the "Open in Stackblitz" to all stories that had the Canvas already setup.

In this issue it should be added the to the variants that don't have it. There is no need to add additional docs, the <Canvas /> should be enough.

Example:

<Canvas
  of={Component.Default}
  additionalActions={[
    {
      title: 'Open in Stackblitz',
      onClick: () => stackblitzPrefillConfig(Component.Default),
    },
  ]}
/>

Note: After adding the code, it should be tested by opening it in Stackblitz to ensure everything works as expected. Some stories might not function properly in Stackblitz, so we’ll need to evaluate whether they can be fixed or not.

@JuanMacias153
Copy link

Hi, my team would like to work on this issue, could we get it assigned?

@guidari
Copy link
Contributor Author

guidari commented Jan 20, 2025

Hey @JuanMacias153
Looks like @heloiselui is already assigned to it.

If you want we can find other issues for your team to work!
We have this umbrella issue related to PolymorphicProps. I'm happy to open issues, if you guys want to work on it! 🙂

@heloiselui heloiselui moved this from ⏱ Backlog to 🏗 In Progress in Design System Jan 20, 2025
@JuanMacias153
Copy link

Hi @guidari, I would love to work on an the project, is there any "good first issue" ones that you are able to open up? My team are willing to contribute in any way that they can. Thank you so much! 🙂

@guidari
Copy link
Contributor Author

guidari commented Jan 24, 2025

You guys can grab anything in the queue that was already triaged.

If you want an issue, just make a comment on it, so a Carbon member can assign you.

@tay1orjones
Copy link
Member

tay1orjones commented Jan 24, 2025

@guidari @heloiselui I just want to be sure we're not losing track of

Is the intent to revise playground stories and move args to all the default stories as part of this workstream or no? If so, it would be good to include that as part of the acceptance criteria for the PR(s) towards this issue. If not, we should work together to get a list going in #16816 of all the components that need their playground stories removed and args added to all the other stories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue 👋 Used by GitHub to elevate contribution opportunities planning: umbrella Umbrella issues, surfaced in Projects views role: dev 🤖 type: docs 📖
Projects
Status: 🏗 In Progress
Development

No branches or pull requests

4 participants