Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable with expansion does not work with sticky header #3912

Open
2 tasks done
gmoehler opened this issue Sep 5, 2019 · 6 comments
Open
2 tasks done

DataTable with expansion does not work with sticky header #3912

gmoehler opened this issue Sep 5, 2019 · 6 comments
Labels
component: data-table role: dev 🤖 severity: 3 https://ibm.biz/carbon-severity type: bug 🐛 version: 11 Issues pertaining to Carbon v11

Comments

@gmoehler
Copy link
Contributor

gmoehler commented Sep 5, 2019

Brief description

DataTables with expansion are not yet supported very well with sticky header. The pulldown is somewhat mis-aligned with the rest of the row.

What package(s) are you using?

latest

  • carbon-components
  • carbon-components-react

Detailed description

Describe in detail the issue you're having.
When using the appropriate styles in Vanilla JS or the new stickyHeader flag in the react component (#3875) along with expansion the row does not look properly (see screenshot)

Is this issue related to a specific component?
DataTable

What did you expect to happen? What happened instead? What would you like to
see changed?
row should look the same with or without sticky header

What browser are you working in?
chrome / firefox

What version of the Carbon Design System are you using?
latest

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?
IBM Cloud SQL Query

Steps to reproduce the issue

  1. Select DataTable with expansion in storyboard
  2. In Knows turn on the sticky header option
  3. The table rows are no longer showing up properly

Additional information

  • Screenshots

Screenshot 2019-09-05 at 15 02 23

@tw15egan
Copy link
Collaborator

Seems to still be an issue

@sstrubberg
Copy link
Member

Is this relevant @gmoehler ?

@gmoehler
Copy link
Contributor Author

@sstrubberg sorry for the late response. in fact we have been using a sticky table unchanged since that time in the product, and had to add a number of css styles to make it working. Unfortunatelly, the current carbon 10 react storybook no longer has the option to set parameters via knobs, so it is hard to easily prove its current state. So I assume it is still relevant.

@tyranasaurus
Copy link

This is still an issue.

@tay1orjones
Copy link
Member

Yeah, here's an example of it in the current storybook

Image

@tay1orjones tay1orjones added the severity: 3 https://ibm.biz/carbon-severity label Feb 22, 2024
@tay1orjones
Copy link
Member

@gmoehler could you share some of the overrides you've made to get this working? Would love to get those fixes upstream here if possible!

@tay1orjones tay1orjones moved this from 🕵️‍♀️ Triage to ⏱ Backlog in Design System Feb 22, 2024
@tay1orjones tay1orjones added the version: 11 Issues pertaining to Carbon v11 label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data-table role: dev 🤖 severity: 3 https://ibm.biz/carbon-severity type: bug 🐛 version: 11 Issues pertaining to Carbon v11
Projects
Status: ⏱ Backlog
Development

No branches or pull requests

7 participants