Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: text area component - masking #9889

Open
1 task done
dpklahn opened this issue Oct 18, 2021 · 6 comments
Open
1 task done

[Feature Request]: text area component - masking #9889

dpklahn opened this issue Oct 18, 2021 · 6 comments
Labels
component: text-area needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. status: help wanted 👐 type: enhancement 💡 version: 11 Issues pertaining to Carbon v11

Comments

@dpklahn
Copy link

dpklahn commented Oct 18, 2021

Summary

(design & development needed)

The multi-line text area input to support the following:

  1. warning state - currently, only an error state is supported.
  2. masking - currently, credentials entered in multi-line text area cannot be masked.

Justification

  1. Warning state: We need to warn users (but not prevent) when a leading/trailing space exists. Our forms contain a variety of multi-line, single-line, and number input fields - we cannot only provide warning feedback for some fields and not others. related GH issue

  2. Masking: Some credentials in connection forms require multi-line input & the ability to mask the input. related GH issue
    a. Usability issue: we cannot ask users to input JSON snippets into a single-line input.
    b. Security issue: we cannot expose user credentials in the UI when using multi-line input (i.e. exposing the user's password).

Desired UX and success metrics

  1. Text area supports a warning state similar to the text input (single-line) and number input fields. Should include a visual indication (with color) and text string that allows users to immediately identify the warning state and read an explanation of the warning.
  2. Text area supports a masking capability similar to the text input that allows users to toggle on/off the visibility of the input.

Metrics for success/failure: users should be able to easily identify the the warning state and masking capability & recognize that they behave the same as the single-line text input.

Required functionality

The two enhancements to the text area should contain all the same functionality as in the single-line text input.

Specific timeline issues / requests

No upcoming release. The masking capability is a security concern and should be addressed asap.

Available extra resources

No response

Code of Conduct

@dpklahn
Copy link
Author

dpklahn commented Oct 18, 2021

cc @kareng

@jnm2377 jnm2377 added proposal: open This request has gone through triaging. We're determining whether we take this on or not. and removed status: needs triage 🕵️‍♀️ labels Oct 20, 2021
@dakahn
Copy link
Contributor

dakahn commented Nov 22, 2021

This seems cool to us considering out single line text inputs have these features. Thanks for the thorough issue 👍🏾

@dakahn dakahn added proposal: accepted This request has gone through triaging and we are accepting PR's against it. and removed proposal: open This request has gone through triaging. We're determining whether we take this on or not. labels Nov 22, 2021
@dpklahn
Copy link
Author

dpklahn commented Jul 22, 2022

Hi, I see this request was accepted and the work for adding a warning state has started, which is awesome!

Any idea on the masking capability and if/when that might make it in?

@tay1orjones tay1orjones moved this to Accepted in Roadmap Aug 24, 2022
@sstrubberg sstrubberg moved this to 🥶 Ice Box in Design System Sep 19, 2022
@sstrubberg
Copy link
Member

Notes from our backlog cleaning earlier today.

  • We could use some design specs around both the warning state and masking issues. If possible, broken out into different GH issues for tracking.
  • Related to the first bullet - Carbon devs estimate the warning state would be easier to implement than the masking
  • We expect the Multi-line TextArea to have the same capability as the single line. - Form parity.

Reached out to @dpklahn on Slack for further clarification. Pending the priority of this work, it might be a a good candidate for a community contribution.

@sstrubberg sstrubberg moved this from Accepted to TextArea in Roadmap Oct 12, 2022
@sstrubberg sstrubberg moved this from 🥶 Ice Box to 🕵️‍♀️ Triage in Design System Nov 30, 2022
@tay1orjones tay1orjones moved this from 🕵️‍♀️ Triage to 🪆 Needs Refined in Design System Dec 6, 2022
@sstrubberg sstrubberg added component: text-area package: @carbon/react @carbon/react version: 11 Issues pertaining to Carbon v11 labels Dec 7, 2022
@sstrubberg sstrubberg moved this from TextArea to Backlog in Roadmap Dec 12, 2022
@sstrubberg sstrubberg moved this from Backlog to Icebox in Roadmap Dec 16, 2022
@tay1orjones
Copy link
Member

The warning state has been delivered #13293

The only remaining item for this issue is the masking.

@tay1orjones tay1orjones changed the title [Feature Request]: text area component - warning state & masking [Feature Request]: text area component - masking Apr 26, 2023
@sstrubberg sstrubberg moved this from Icebox to Next in Roadmap Apr 26, 2023
@sstrubberg sstrubberg added this to the 2023 Q3 milestone Apr 26, 2023
@tay1orjones tay1orjones modified the milestones: 2023 Q3, 2023 Q4 Oct 2, 2023
@tay1orjones tay1orjones moved this from Next to Now in Roadmap Oct 2, 2023
@tay1orjones tay1orjones modified the milestones: 2023 Q4, 2024 Q1 Jan 11, 2024
@sstrubberg sstrubberg moved this from Now to Ready for community implementation in Roadmap Feb 27, 2024
@sstrubberg sstrubberg added needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. status: help wanted 👐 labels Feb 27, 2024
Copy link
Contributor

The Carbon team has accepted this proposal! Our team doesn't have the capacity to work on this now, so we are requesting community contributors. Please see the labels for roles that are needed. If you are willing to help out, comment below and we will get in touch!

@tay1orjones tay1orjones modified the milestones: 2024 Q1, 2024 Q2 Apr 3, 2024
@sstrubberg sstrubberg modified the milestones: 2024 Q2, 2024 Q3 Jul 2, 2024
@sstrubberg sstrubberg removed this from the 2024 Q3 milestone Sep 10, 2024
@sstrubberg sstrubberg moved this to 📋 Backlog in Community Workgroups Sep 10, 2024
@sstrubberg sstrubberg moved this from Ready for community implementation to Icebox 🧊 in Roadmap Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: text-area needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. status: help wanted 👐 type: enhancement 💡 version: 11 Issues pertaining to Carbon v11
Projects
Status: 📋 Backlog
Status: Later 🧊
Development

No branches or pull requests

5 participants