From a09a65ce692eaf7c6f7facebdd4fd51c70de6b2f Mon Sep 17 00:00:00 2001 From: guidari Date: Wed, 4 Oct 2023 12:24:18 -0300 Subject: [PATCH 1/3] fix: added aria-live to stop extraneous announcement --- packages/react/src/components/DataTable/TableRow.tsx | 2 +- packages/react/src/components/DataTable/TableSelectAll.tsx | 1 + packages/react/src/components/DataTable/TableSelectRow.tsx | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/react/src/components/DataTable/TableRow.tsx b/packages/react/src/components/DataTable/TableRow.tsx index c2585c46fcc2..700929953a3a 100644 --- a/packages/react/src/components/DataTable/TableRow.tsx +++ b/packages/react/src/components/DataTable/TableRow.tsx @@ -41,7 +41,7 @@ const TableRow = (props: TableRowProps) => { ]), className: className || undefined, }; - return ; + return ; }; TableRow.propTypes = { diff --git a/packages/react/src/components/DataTable/TableSelectAll.tsx b/packages/react/src/components/DataTable/TableSelectAll.tsx index ab5367e1fb85..f219da20fa82 100644 --- a/packages/react/src/components/DataTable/TableSelectAll.tsx +++ b/packages/react/src/components/DataTable/TableSelectAll.tsx @@ -66,6 +66,7 @@ const TableSelectAll = ({ const prefix = usePrefix(); return ( + Date: Wed, 4 Oct 2023 12:30:01 -0300 Subject: [PATCH 2/3] fix: remove aria-live --- packages/react/src/components/DataTable/TableRow.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react/src/components/DataTable/TableRow.tsx b/packages/react/src/components/DataTable/TableRow.tsx index 700929953a3a..c2585c46fcc2 100644 --- a/packages/react/src/components/DataTable/TableRow.tsx +++ b/packages/react/src/components/DataTable/TableRow.tsx @@ -41,7 +41,7 @@ const TableRow = (props: TableRowProps) => { ]), className: className || undefined, }; - return ; + return ; }; TableRow.propTypes = { From fba268de4e6489e42b6b01bfd515095039e0f2c2 Mon Sep 17 00:00:00 2001 From: guidari Date: Wed, 4 Oct 2023 14:50:11 -0300 Subject: [PATCH 3/3] test: updated sanpshots --- .../__tests__/__snapshots__/DataTable-test.js.snap | 10 ++++++++++ .../__snapshots__/TableSelectRow-test.js.snap | 1 + 2 files changed, 11 insertions(+) diff --git a/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap b/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap index a00dbc7d6598..76fbe8b34092 100644 --- a/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap +++ b/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap @@ -53,6 +53,7 @@ exports[`DataTable behaves as expected selection -- radio buttons should not hav >
@@ -667,6 +674,7 @@ exports[`DataTable behaves as expected selection should render and match snapsho >