Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: slider component does not handle zero properly #16327

Merged
merged 7 commits into from
May 13, 2024
Merged

fix: slider component does not handle zero properly #16327

merged 7 commits into from
May 13, 2024

Conversation

preetibansalui
Copy link
Contributor

Closes #15916

Slider Component does not handle Zero properly

Testing / Reviewing

  1. Go to slider and add non zero items as min & max values (eg: -10 to -1)
  2. Now enter zero in input box, it should auto correct the value to nearest possible value.
  3. It should display the auto correct message properly.

@preetibansalui preetibansalui requested a review from a team as a code owner May 6, 2024 11:28
@netlify Netlify
Copy link

netlify bot commented May 6, 2024 •
edited
Loading

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a06b254
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6641a7d6bd93a60008850b46
😎 Deploy Preview https://deploy-preview-16327--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Gururajj77
Gururajj77 approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@Gururajj77 Gururajj77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@preetibansalui preetibansalui requested a review from a team as a code owner May 8, 2024 11:10
guidari
guidari approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM!

@guidari guidari added this pull request to the merge queue May 13, 2024
Merged via the queue into carbon-design-system:main with commit 8293f95 May 13, 2024
20 checks passed
This was referenced Jun 20, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gururajj77 Gururajj77 Gururajj77 approved these changes

@2nikhiltom 2nikhiltom 2nikhiltom approved these changes

@guidari guidari guidari approved these changes

@tay1orjones tay1orjones Awaiting requested review from tay1orjones tay1orjones was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready for review 👀 status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Slider component does not handle zero properly when it's outside of min/max values
4 participants
@preetibansalui @guidari @2nikhiltom @Gururajj77