fix(combobox): controlled combobox clear #18041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update the way onChange is called in comboBox to prevent unwanted calls * add unit test cases for controlled combobox managed by parent component
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18041 +/- ##
=======================================
Coverage 82.14% 82.15%
=======================================
Files 404 404
Lines 14117 14121 +4
Branches 4434 4442 +8
=======================================
+ Hits 11597 11601 +4
+ Misses 2359 2358 -1
- Partials 161 162 +1 ☔ View full report in Codecov by Sentry. |
tay1orjones
approved these changes
Nov 13, 2024
1 task
* fix withLayer proptypes * add required onChange prop to examples in ComboBox.mdx
Merged
via the queue into
carbon-design-system:main
with commit Nov 14, 2024
1009bab
40 checks passed
2 tasks
2 tasks
k02pradeep
suggested changes
Dec 6, 2024
| onChange({ selectedItem: newSelectedItem }); | ||
| } | ||
| if ( | ||
| type === '__function_select_item__' || |
There was a problem hiding this comment.
This pull request is already merged, and a fix for this has also been merged, see #18145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18027
Testing / Reviewing