Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unnecessary duplicate inserts of code #36

Open
photodow opened this issue Oct 2, 2020 · 0 comments
Open

Prevent unnecessary duplicate inserts of code #36

photodow opened this issue Oct 2, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@photodow
Copy link
Contributor

photodow commented Oct 2, 2020

I've done a lot to clean this up already where the code just kept getting injected every time the page was validated, but there may be still some work still around this particular as it relates to the validation step. It's not a huge issue at the moment, but something I want to keep an eye on and fix as soon as I get a chance.

We've used declarativeContent before, but could it be used to continue validating a page after it's been injected?https://developer.chrome.com/extensions/declarativeContent

https://github.com/carbon-design-system/devtools/blob/master/App/background/tasks/validatePage.js#L17-L21

@photodow photodow added the bug Something isn't working label Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant