Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multiaddselect]: admin/editor role can open the dropdown #5450

Closed
2 tasks done
ariellalgilmore opened this issue Jun 10, 2024 · 5 comments
Closed
2 tasks done

[Multiaddselect]: admin/editor role can open the dropdown #5450

ariellalgilmore opened this issue Jun 10, 2024 · 5 comments
Assignees
Labels
component: AddSelect role: dev Sev 4 Not visible to or noticeable to users. Affects minor functionality, no workaround needed. type: bug 🐛 Something isn't working

Comments

@ariellalgilmore
Copy link
Member

Package

Carbon for IBM Products

Description

The "role" (ie admin, editor, etc.) dropdown can be open/closed when clicking on the text "Role". Seems like only the dropdown itself should be able to do this.

Screen.Recording.2024-06-10.at.12.41.19.PM.mov

Component(s) impacted

multiaddselect

Browser

No response

@carbon/ibm-products (previously @carbon/ibm-cloud-cognitive) version

2.41.0

Severity

Severity 4 = The problem is not visible to or noticeable to an average user. Affects minor functionality, no workaround needed.

Product/offering

n/a

CodeSandbox or Stackblitz example

https://carbon-for-ibm-products.netlify.app/?path=/story/ibm-products-patterns-add-and-select-multiaddselect--with-modifiers&globals=viewport:basic

Steps to reproduce the issue (if applicable)

go to: https://carbon-for-ibm-products.netlify.app/?path=/story/ibm-products-patterns-add-and-select-multiaddselect--with-modifiers&globals=viewport:basic

click on one of the checkbox "items" and then click on the "role" next to the dropdown

Release date (if applicable)

No response

Code of Conduct

@github-project-automation github-project-automation bot moved this to Needs triage 🧐 in Carbon for IBM Products Jun 10, 2024
@elycheea elycheea added component: AddSelect type: bug 🐛 Something isn't working Sev 4 Not visible to or noticeable to users. Affects minor functionality, no workaround needed. role: dev and removed status: needs triage 🕵️‍♀️ labels Jun 14, 2024
@elycheea elycheea moved this from Needs triage 🧐 to Backlog 🌋 in Carbon for IBM Products Jun 14, 2024
@davidmenendez davidmenendez self-assigned this Jun 18, 2024
@davidmenendez davidmenendez moved this from Backlog 🌋 to In progress in Carbon for IBM Products Jun 18, 2024
@davidmenendez
Copy link
Contributor

davidmenendez commented Jun 18, 2024

after some investigation i have confirmed that this is actually a problem with Dropdown within Tearsheet. here's a stackblitz replicating the behavior https://stackblitz.com/edit/github-csnnba-wu3lci?file=src%2FExample%2FExample.jsx

i'll keep this issue open since everything is already documented here.

@davidmenendez
Copy link
Contributor

further investigation shows this problem persists through the carbon ComposedModal. i will have to do some additional debugging and submit my fix to core.

you can see the problem persisting in their storybook https://react.carbondesignsystem.com/?path=/story/components-composedmodal--with-scrolling-content

@davidmenendez
Copy link
Contributor

I've traced the bug back to core and will be submitting a fix there. issue for reference carbon-design-system/carbon#16846

@davidmenendez davidmenendez moved this from In progress to In review 👀 in Carbon for IBM Products Jun 24, 2024
@davidmenendez
Copy link
Contributor

just waiting on the PR in carbon to be merged carbon-design-system/carbon#16847

@davidmenendez
Copy link
Contributor

carbon-design-system/carbon#16847 has been merged. fix should be included in the next carbon release. closing issue 🎉

@github-project-automation github-project-automation bot moved this from In review 👀 to Done 🚀 in Carbon for IBM Products Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: AddSelect role: dev Sev 4 Not visible to or noticeable to users. Affects minor functionality, no workaround needed. type: bug 🐛 Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants