Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagrid: slug --> aiLabel renaming #6097

Closed
5 tasks
Tracked by #6092
matthewgallo opened this issue Sep 23, 2024 · 1 comment · Fixed by #6151
Closed
5 tasks
Tracked by #6092

Datagrid: slug --> aiLabel renaming #6097

matthewgallo opened this issue Sep 23, 2024 · 1 comment · Fixed by #6151
Assignees
Labels
area: AI Used to filter issues in the Carbon for AI project. component: Datagrid

Comments

@matthewgallo
Copy link
Member

matthewgallo commented Sep 23, 2024

Tasks

Preview Give feedback

For duplicate class, this is an example:

- .#{$prefix}--slug .#{$prefix}--slug__button {

+ .#{$prefix}--slug .#{$prefix}--slug__button,
+ .#{$prefix}--ai-label .#{$prefix}--ai-label__button {

Image

@wkeese
Copy link
Contributor

wkeese commented Sep 25, 2024

Hmm, I don't like the sounds of that... because we are using the slug for another purpose. Relatedly, see the ticket carbon-design-system/carbon#17303 that I filed.

@sangeethababu9223 sangeethababu9223 moved this from Backlog 🌋 to In progress in Carbon for IBM Products Sep 30, 2024
@sangeethababu9223 sangeethababu9223 moved this from In progress to Needs review 👋 in Carbon for IBM Products Oct 7, 2024
@github-project-automation github-project-automation bot moved this from Needs review 👋 to Done 🚀 in Carbon for IBM Products Oct 22, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Carbon for AI Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: AI Used to filter issues in the Carbon for AI project. component: Datagrid
Projects
Status: ✅ Done
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants