Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notification panel keyboard close focus #6113

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

davidmenendez
Copy link
Contributor

Closes #6010

fixes a small timing issue that was preventing the notification panel from regaining focus after closing via keyboard.

you can verify the fix by following the Steps to reproduce the issue (if applicable) and verifying that the focus is regained.

@davidmenendez davidmenendez requested a review from a team as a code owner September 24, 2024 20:28
@davidmenendez davidmenendez requested review from makafsal and sangeethababu9223 and removed request for a team September 24, 2024 20:28
Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 949f724
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66f320f060bbd2000850b051
😎 Deploy Preview https://deploy-preview-6113--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@elycheea elycheea added this pull request to the merge queue Sep 26, 2024
Merged via the queue into carbon-design-system:main with commit 752739b Sep 26, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Notification Panel]: Dismiss all breaks focus flow between the notification panel and the global header
5 participants