Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(carousel): adds test to increase coverage #6393

Conversation

AlexanderMelox
Copy link
Contributor

Closes #6261

This PR adds more test coverage

How did you test and verify your work?

Running local test scripts

@AlexanderMelox AlexanderMelox requested a review from a team as a code owner November 7, 2024 19:07
@AlexanderMelox AlexanderMelox requested review from davidmenendez and anamikaanu96 and removed request for a team November 7, 2024 19:07
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 60d9b27
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/6745d98fc5d7f80008899feb
😎 Deploy Preview https://deploy-preview-6393--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 60d9b27
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6745d98f3a0bed0008c53018
😎 Deploy Preview https://deploy-preview-6393--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.86%. Comparing base (9d07dab) to head (60d9b27).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6393      +/-   ##
==========================================
+ Coverage   79.84%   79.86%   +0.02%     
==========================================
  Files         394      394              
  Lines       12877    12877              
  Branches     4258     4258              
==========================================
+ Hits        10281    10284       +3     
+ Misses       2596     2593       -3     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

Copy link
Contributor

@anamikaanu96 anamikaanu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AlexanderMelox The coverage is now 79.41%, can you try to increase upto 80% may be we can add handleKeydown/handleWheel.

@AlexanderMelox
Copy link
Contributor Author

AlexanderMelox commented Nov 21, 2024

@anamikaanu96 Will be adding a few more tests,thanks

@AlexanderMelox
Copy link
Contributor Author

@anamikaanu96 I realized that this is the component that I couldn't get the other tests to work. I spoke with @matthewgallo about this issue and i think the code coverage for this component is good enough. So we can merge this PR as is and add the 2% coverage another time. Thanks!

Copy link
Contributor

@amal-k-joy amal-k-joy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.
We can create another issue to track for the remaining coverage.

@amal-k-joy amal-k-joy enabled auto-merge November 25, 2024 16:09
@amal-k-joy amal-k-joy added this pull request to the merge queue Dec 3, 2024
Merged via the queue into carbon-design-system:main with commit b2298b5 Dec 3, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase Carousel code coverage
4 participants