-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(carousel): adds test to increase coverage #6393
test(carousel): adds test to increase coverage #6393
Conversation
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6393 +/- ##
==========================================
+ Coverage 79.84% 79.86% +0.02%
==========================================
Files 394 394
Lines 12877 12877
Branches 4258 4258
==========================================
+ Hits 10281 10284 +3
+ Misses 2596 2593 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AlexanderMelox The coverage is now 79.41%, can you try to increase upto 80% may be we can add handleKeydown/handleWheel.
@anamikaanu96 Will be adding a few more tests,thanks |
@anamikaanu96 I realized that this is the component that I couldn't get the other tests to work. I spoke with @matthewgallo about this issue and i think the code coverage for this component is good enough. So we can merge this PR as is and add the 2% coverage another time. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
We can create another issue to track for the remaining coverage.
b2298b5
Closes #6261
This PR adds more test coverage
How did you test and verify your work?
Running local test scripts