chore: improve percy snapshot coverage #6520
Draft
+320
−453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devadula-nandan
requested review from
makafsal and
sangeethababu9223
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
devadula-nandan
changed the title
|
The AVTs need to be addressed, as they are currently activated manually by clicking the trigger button. Some cleanup is required. also cant get options tile to open. it opens if we pass open prop, but doesnt close, need to investigate if we need to toggle open state with some onclick on options tile. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6520 +/- ##
=======================================
Coverage 79.95% 79.96%
=======================================
Files 394 394
Lines 12914 12915 +1
Branches 4280 4280
=======================================
+ Hits 10326 10328 +2
+ Misses 2588 2587 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6512
opens components default state
What did you change?
change the default state of the components to open, story only change.
How did you test and verify your work?
percy tests, storybook