From 4e0c631a35c0a20a8cb7a6a368489dd4f5d02b39 Mon Sep 17 00:00:00 2001 From: Matt Gallo Date: Thu, 12 Dec 2024 11:19:47 -0500 Subject: [PATCH 1/2] build: comment out vrt in ci.yml to test if running from netlify works --- .github/workflows/ci.yml | 42 ++++++++++++++++++++-------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ca430ab0d1..2d6d51193e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -182,27 +182,27 @@ jobs: name: playwright-avt-report path: .playwright - vrt-runner: - runs-on: ubuntu-latest - steps: - - name: Checkout - uses: actions/checkout@v2 - - name: Setup Node.js - uses: actions/setup-node@v2 - with: - node-version: '20.x' - cache: yarn - - name: Install - run: yarn - - name: Install browsers - run: yarn playwright install --with-deps - - name: Build project - run: yarn build - - name: Run VRT - working-directory: packages/core - env: - PERCY_TOKEN: web_d04495b0b413d61c2ea6b9118d1748b43f4fdd58d17ebe453ef8e0016b5766e4 - run: yarn percy storybook storybook-static + # vrt-runner: + # runs-on: ubuntu-latest + # steps: + # - name: Checkout + # uses: actions/checkout@v2 + # - name: Setup Node.js + # uses: actions/setup-node@v2 + # with: + # node-version: '20.x' + # cache: yarn + # - name: Install + # run: yarn + # - name: Install browsers + # run: yarn playwright install --with-deps + # - name: Build project + # run: yarn build + # - name: Run VRT + # working-directory: packages/core + # env: + # PERCY_TOKEN: web_d04495b0b413d61c2ea6b9118d1748b43f4fdd58d17ebe453ef8e0016b5766e4 + # run: yarn percy storybook storybook-static avt: if: ${{ always() }} From 6cfcae5038944c5bb21416ba240f6be2786832c3 Mon Sep 17 00:00:00 2001 From: Matt Gallo Date: Thu, 12 Dec 2024 11:45:51 -0500 Subject: [PATCH 2/2] refactor: remove vrt step completely --- .github/workflows/ci.yml | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2d6d51193e..51aa7c1f42 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -182,28 +182,6 @@ jobs: name: playwright-avt-report path: .playwright - # vrt-runner: - # runs-on: ubuntu-latest - # steps: - # - name: Checkout - # uses: actions/checkout@v2 - # - name: Setup Node.js - # uses: actions/setup-node@v2 - # with: - # node-version: '20.x' - # cache: yarn - # - name: Install - # run: yarn - # - name: Install browsers - # run: yarn playwright install --with-deps - # - name: Build project - # run: yarn build - # - name: Run VRT - # working-directory: packages/core - # env: - # PERCY_TOKEN: web_d04495b0b413d61c2ea6b9118d1748b43f4fdd58d17ebe453ef8e0016b5766e4 - # run: yarn percy storybook storybook-static - avt: if: ${{ always() }} runs-on: ubuntu-latest