-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: recompose dependency causes React warnings #602
Comments
Thanks for raising! As a minimum, this requires us refactoring anywhere in production ( |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
yes, it is still relevant
|
Recompose has a transitive dependency on node-fetch ^1.0.1, which is flagged as a security vulnerability by yarn audit. |
Potential solution - acdlite/recompose#817 (comment) |
🎉 This issue has been resolved in version 1.45.0-prerelease.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 1.45.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Expected behavior -
When rendering components from
@carbon/ibm-security
the web console should be as clean as possible when there are not prop-type errors. This way, we can reduce console noise and focus on real issues.Actual behavior -
When rendering components from
@carbon/ibm-security
, we get numerous warnings that look like this:When digging further, here is what I see:
Notice that the stack trace highlights
recompose
used by theTagWallFilter
component. I dug deeper and found this comment. It appears thatrecompose
is causing the problem.Additionally, the
recompose
project has been sunset close to two years ago.Steps for reproducing
Optional information
Version - 1.25.0
The text was updated successfully, but these errors were encountered: