Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: recompose dependency causes React warnings #602

Closed
diego-codes opened this issue Jun 9, 2020 · 7 comments · Fixed by #1059
Closed

Bug: recompose dependency causes React warnings #602

diego-codes opened this issue Jun 9, 2020 · 7 comments · Fixed by #1059
Assignees
Labels
help wanted Extra attention is needed released on @canary released type: bug Something isn't working

Comments

@diego-codes
Copy link
Contributor

Expected behavior -
When rendering components from @carbon/ibm-security the web console should be as clean as possible when there are not prop-type errors. This way, we can reduce console noise and focus on real issues.

Actual behavior -

When rendering components from @carbon/ibm-security, we get numerous warnings that look like this:

console.warn node_modules/react/cjs/react.development.js:315
    Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

When digging further, here is what I see:
image

Notice that the stack trace highlights recompose used by the TagWallFilter component. I dug deeper and found this comment. It appears that recompose is causing the problem.

Additionally, the recompose project has been sunset close to two years ago.

Steps for reproducing

  1. Render any component with the following style of import:
    import { Button } from '@carbon/ibm-security';
    
  2. Check the console and notice the warning.

Optional information

Version - 1.25.0

@SimonFinney SimonFinney added type: bug Something isn't working severity 4 labels Jun 10, 2020
@SimonFinney
Copy link
Contributor

SimonFinney commented Jun 10, 2020

Thanks for raising! As a minimum, this requires us refactoring anywhere in production (TagWallFilter) that uses the recompose package to hooks, and either moving it to devDependencies or removing it entirely

@SimonFinney SimonFinney self-assigned this Jun 10, 2020
@SimonFinney SimonFinney removed their assignment Jul 23, 2020
@SimonFinney SimonFinney added severity: 3 Low severity and removed severity: 4 labels Nov 18, 2020
@stale
Copy link

stale bot commented Jan 18, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix This will not be worked on label Jan 18, 2021
@Nikita-Samoilenko
Copy link

yes, it is still relevant
` console.warn
Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

  138 | };
  139 | 
> 140 | export default compose(
      |                ^`

@stale stale bot removed the wontfix This will not be worked on label Jan 18, 2021
@SimonFinney SimonFinney added severity: 2 Medium severity status: triage and removed severity: 3 Low severity severity: 2 Medium severity labels Feb 8, 2021
@SimonFinney SimonFinney self-assigned this Mar 4, 2021
@SimonFinney SimonFinney removed their assignment Mar 4, 2021
@obambrough
Copy link

Recompose has a transitive dependency on node-fetch ^1.0.1, which is flagged as a security vulnerability by yarn audit.

@SimonFinney
Copy link
Contributor

Recompose has a transitive dependency on node-fetch ^1.0.1, which is flagged as a security vulnerability by yarn audit.

Potential solution - acdlite/recompose#817 (comment)

@SimonFinney
Copy link
Contributor

🎉 This issue has been resolved in version 1.45.0-prerelease.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SimonFinney
Copy link
Contributor

🎉 This issue has been resolved in version 1.45.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed released on @canary released type: bug Something isn't working
Projects
None yet
4 participants