Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CbReport validation, report ids & ints #3

Open
jjguy opened this issue Feb 6, 2015 · 0 comments
Open

CbReport validation, report ids & ints #3

jjguy opened this issue Feb 6, 2015 · 0 comments

Comments

@jjguy
Copy link
Contributor

jjguy commented Feb 6, 2015

feed.py", line 175, in validate() has the following line:

    if not re.match("^[a-zA-Z0-9-_.]+$", self.data["id"]):

The use of regex presumes the report id field is a string. If it's an int, this line blows up with an obscure error.

Validation should either (a) exception on int report ids or (b) coerce ints to strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant