Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Appears to have trouble with forked repos #29

Open
hannahhoward opened this issue Jan 5, 2018 · 1 comment
Open

Bug: Appears to have trouble with forked repos #29

hannahhoward opened this issue Jan 5, 2018 · 1 comment
Labels

Comments

@hannahhoward
Copy link
Contributor

hannahhoward commented Jan 5, 2018

Steps to reproduce:

  1. Install funnel on a repo
  2. Fork that repo to another person/organization
  3. Make a properly rebased and squashed branch on the forked repo
  4. Submit a PR from the forked repo to the original

Pretty sure Funnel will fail

See current status on #28 - I believe it's rebased and squashed.

@outofambit outofambit added this to the Public Release milestone Mar 13, 2018
@outofambit outofambit added the bug label Apr 5, 2018
@outofambit
Copy link
Contributor

Yes this true, and something that should be fixed. The cause is that a Scent only captures the user and repo name of the pushed to branch. This works fine for branches in the same repo, but not those in different ones.

I think the solution to this is to modify

@spec get_scent_from_pull_request(%{}) :: %__MODULE__{}
to capture this extra information from the GitHub webhook and then utilize it in https://github.com/carbonfive/funnel/blob/master/lib/funnel/investigator/strategy.ex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants