Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android fill value issues in texture mode #107

Open
Shane98c opened this issue Feb 27, 2024 · 0 comments
Open

Android fill value issues in texture mode #107

Shane98c opened this issue Feb 27, 2024 · 0 comments

Comments

@Shane98c
Copy link
Member

Shane98c commented Feb 27, 2024

Testing on a pixel 6a with latest chrome (also reproducible on firefox for android):

  • fill value of 9.969209968386869e36 is not being discarded and instead rendered as a very large number
  • maps/src/shaders.js

    Lines 152 to 154 in b9782db

    if (${vars[0]} == fillValue) {
    discard;
    }
  • based on debugging it looks like the fill value is being treated as at least an order of mag larger number than it is, we were able to extract the expected fill value using the region picker, so the issue appears to be in the fragment shader.
  • Reproduced in prototype-maps https://github.com/carbonplan/prototype-maps (issue initially noticed in https://github.com/carbonplan/oae-web).
  • Also tested with toggling forest-carbon viewer to use 'texture' and saw initial flash of the issue, soon corrected by

yellow areas are the fillValue areas, continent interiors are manually filled with zeros in the below screenshot.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant