Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Alba bounded algorithm #25

Closed
rrtoledo opened this issue Oct 1, 2024 · 0 comments · Fixed by #33
Closed

Review Alba bounded algorithm #25

rrtoledo opened this issue Oct 1, 2024 · 0 comments · Fixed by #33
Assignees
@tolikzinovyev @curiecrypt

Comments

@rrtoledo
Copy link
Collaborator

rrtoledo commented Oct 1, 2024

This issue aims at ensuring that the implemented algorithm has been implemented correctly.
The task consists in:

  • reviewing the code
  • fixing any bug, comments
  • writing down todos for future optimizations and refactorization
@rrtoledo rrtoledo mentioned this issue Oct 8, 2024
Merged
9 tasks
@rrtoledo rrtoledo linked a pull request Oct 8, 2024 that will close this issue
Adding centralised alba (bounded scheme) #33
Merged
9 tasks
rrtoledo added a commit that referenced this issue Nov 1, 2024
@rrtoledo
Adding centralised alba (bounded scheme) (#33)
d98d9e8 
## Content
Adding Bounded scheme (section 3.2.2 ) implementation in Rust with
randomized tests and benches.

This PR includes...

## Pre-submit checklist

- Branch
    - [x] Tests are provided (if possible)
    - [x] Commit sequence broadly makes sense
    - [x] Key commits have useful messages
- PR
    - [x] No clippy warnings in the CI
    - [x] Self-reviewed the diff
    - [x] Useful pull request description
    - [x] Reviewer requested
- Documentation
    - [ ] Update README file (if relevant)
    - [ ] Update documentation website (if relevant)

## Comments
Repetition bench doesn't work so is disabled
<!-- Some optional comments about the PR, such as how to run a command,
or warnings about usage, .... -->

## Issue(s)
Issue #25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tolikzinovyev tolikzinovyev

@curiecrypt curiecrypt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding centralised alba (bounded scheme) cardano-scaling/alba
3 participants
@tolikzinovyev @rrtoledo @curiecrypt