Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New manifest format results in Error: author is not a string #10

Closed
djahandarie opened this issue Feb 10, 2024 · 2 comments
Closed

New manifest format results in Error: author is not a string #10

djahandarie opened this issue Feb 10, 2024 · 2 comments

Comments

@djahandarie
Copy link

We updated our manifest to match the type being enforced here:
https://developer.chrome.com/docs/extensions/reference/manifest/author

We had to do this to upgrade to the new "@types/chrome": "^0.0.260" npm package (not sure if it was introduced in exactly this version, but somewhere between 254 and 260)

But this action seems to break with that new format:

Run cardinalby/webext-buildtools-chrome-webstore-upload-action@8db7a005529498d95d3e2e0166f6f4050d2b96a5
  with:
    zipFilePath: yomitan-chrome-dev.zip
    extensionId: ***
    apiAccessToken: ***
    waitForUploadCheckCount: 10
    waitForUploadCheckIntervalMs: 180000
info:    Manifest input is not set, reading from zip...
Error: Error: author is not a string

(I'm not sure where exactly that error is coming from, I wasn't able to find it via some GitHub searching...)

@cardinalby
Copy link
Owner

Hi! Try again from master or v1, I removed the unnecessary validations

@djahandarie
Copy link
Author

It worked!! Thank you so much as always 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants