Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to non-jsonapi serializers #7

Closed

Conversation

josemarluedke
Copy link

This PR makes possible to serialize and push model data using its serializer, allowing us to not require JSONAPI serializer.

I'm sure the code could be refactored to make things more clear. Please let me know what should I change to make this land.

Also, I did not wanted to follow the idea from #4 of having a custom serializer because ember data is deprecating store.serialize and I wasn't sure if that deprecation would apply to the approach of #4.

This closes #3.

@rondale-sc
Copy link

@josemarluedke I'm getting an error that _ isn't defined when it tries to pull in the records. Is it that lodash isn't required by this addon or something?

@josemarluedke
Copy link
Author

Ahhh, that's true. I got this from our app witch has lodash. I will update this PR to not require it.

@rondale-sc
Copy link

rondale-sc commented Jan 25, 2017

@josemarluedke was able to fix with: let recordsToPush = $.extend({}, dump.records)[modelName]; Which should be functionally the same.

@josemarluedke
Copy link
Author

@rondale-sc updated removing the usage of lodash. This should be ready for a review/testing/merging.

@CvX
Copy link

CvX commented Sep 28, 2017

This PR got a little stale, here's an updated version: https://github.com/CvX/ember-data-fastboot/tree/not-only-jsonapi-updated (a rebase of @josemarluedke's work).

@medokin
Copy link

medokin commented Oct 11, 2017

Patiently waiting for this to become ready.

@adentranter
Copy link

Are the people not using JSONAPI using this commit?

Is this going to be merged in at anytime?

What are you guys using currently for ember fastboot data?

Cheers

@medokin
Copy link

medokin commented Apr 12, 2018

@adentranter We are using https://github.com/Appchance/ember-cached-shoe
It works fine with our custom RESTAdapter.

@adentranter
Copy link

@medokin legend. Going to look into that tonight :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't require JSONAPISerializer
5 participants