Any interest in updates? #1
Comments
|
absolutely. would be great to have your contribution. would you be sending a pull request ? |
|
I'm new to github, so while that is what I want to do, I'm needing to figure out how. :-) |
|
I've committed my changed to my local repository and tried to create a pull request, but the button is grayed out. I'm guessing I don't have permission. Or I need to create a branch or something like that. |
|
try this..
https://help.github.com/articles/editing-files-in-another-user-s-repository/
Editing files in another user's repository - User ...<https://help.github.com/articles/editing-files-in-another-user-s-repository/>
help.github.com
In another user's repository, browse to the folder that contains the file you want to edit. Click the name of the file you want to edit. Above the file content, click .
…________________________________
From: hyegeek <[email protected]>
Sent: Saturday, January 28, 2017 8:04:47 AM
To: qwertangel/Hello-You-There
Cc: qwertangel; Comment
Subject: Re: [qwertangel/Hello-You-There] Any interest in updates? (#1)
I've committed my changed to my local repository and tried to create a pull request, but the button is grayed out. I'm guessing I don't have permission. Or I need to create a branch or something like that.
-
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#1 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADLVvtXeu7tkNvvM0KmAPnd0kDPjecc4ks5rW2cfgaJpZM4LwhcN>.
|
|
Thanks. I think I did it. At least the main pages mentions my patch. Let me know what you think. |
|
I can see it now. I created a Pull request so that I can merge it in main repo. Script does look more organized now ! Will merge after I run through it once.
Thanks !
…________________________________
From: hyegeek <[email protected]>
Sent: Saturday, January 28, 2017 8:29:09 AM
To: qwertangel/Hello-You-There
Cc: qwertangel; Comment
Subject: Re: [qwertangel/Hello-You-There] Any interest in updates? (#1)
Thanks. I think I did it. At least the main pages mentions my patch. Let me know what you think.
-
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#1 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADLVvjF2jiGKNisU4ANQtZ3j1ExfFDMnks5rW2zVgaJpZM4LwhcN>.
|
|
It just occurred to me that I'm pointing to a different directory for the sound files. I ended up making a link when I was testing, but I wanted to be able to mess with my own copy without breaking the old one. |
|
updated the folders to match script. Please check. |
|
Looks good to me. While going over the code again last night, I noticed room for another minor improvement. I've submitted that patch as well. |
|
i see that mixmonitor was removed and another line was moved out of loop. is that what you wanted to do ?
…________________________________
From: hyegeek <[email protected]>
Sent: Sunday, January 29, 2017 7:23:10 AM
To: qwertangel/Hello-You-There
Cc: qwertangel; Comment
Subject: Re: [qwertangel/Hello-You-There] Any interest in updates? (#1)
Looks good to me. While going over the code again last night, I noticed room for another minor improvement. I've submitted that patch as well.
-
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#1 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADLVvufDgWWUVbBvqcQuanEs_iV2JRNzks5rXK7egaJpZM4LwhcN>.
|
|
Serves me right for doing things quickly before I leave. That patch did not look like what I wanted. Let me do another that is correct.... OK. New patch looks like what I really wanted. MixMonitor moved. |
|
I see there are several patches you created. Some are related to lenny. Which patch do you think I should pickup ?
…________________________________
From: hyegeek <[email protected]>
Sent: Sunday, January 29, 2017 11:55:25 AM
To: qwertangel/Hello-You-There
Cc: qwertangel; Comment
Subject: Re: [qwertangel/Hello-You-There] Any interest in updates? (#1)
Serves me right for doing things quickly before I leave. That patch did not look like what I wanted. Let me do another that is correct....
OK. New patch looks like what I really wanted. MixMonitor moved.
-
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#1 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADLVvr_cOza5TfxCgj31oJukJyx3rMbpks5rXO6tgaJpZM4LwhcN>.
|
|
One of them is for helloyouthere.txt, that's the one that fixes what I mentioned before. There are 3 other patches that all add files. These are for a proposed way to allow for easy expansion to other sets of clips. The first teletrap.conf would be an include file that would do the work of playing the clips. The other two files are examples of using the teletrap.conf file. One implements the same things that helloyouthere.txt does, the other is an example of implementing lenny with the same include. If you think this ia a good way to go, you can accept the files, if not, just ignore them and only updated the helloyouthere.txt file. |
|
Looking at the list of patches, patch-3 is the one that fixes helloyouthere.txt. The other files patch-4-6, are the patches that add new files. |
|
just merged patch 3. thanks for contribution ! I am sure this script will help lot of people.
…________________________________
From: hyegeek <[email protected]>
Sent: Wednesday, February 1, 2017 6:14:02 AM
To: qwertangel/Hello-You-There
Cc: qwertangel; Comment
Subject: Re: [qwertangel/Hello-You-There] Any interest in updates? (#1)
Looking at the list of patches, patch-3 is the one that fixes helloyouthere.txt. The other files patch-4-6, are the patches that add new files.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#1 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADLVvmfxZKe427w3YLOyZyy7VNLBKNYKks5rYJMqgaJpZM4LwhcN>.
|
While this project is pretty old, the audio files are perfect for trolling the scammers. After setting up the dial plan on my pbx, I wanted to be sure I understood what it was doing. The result of that was a re-write to simplify things a bit and to adjust the silences to flow more naturally.
I'd be happy to contribute what I've done if there is any interest.
The text was updated successfully, but these errors were encountered: