Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support py_trees 1.x #24

Open
fabianoboril opened this issue Jan 22, 2019 · 5 comments
Open

Support py_trees 1.x #24

fabianoboril opened this issue Jan 22, 2019 · 5 comments
Assignees
Labels
backlog enhancement New feature or request

Comments

@fabianoboril
Copy link
Collaborator

Currently we support only py_trees 0.8.x. Now there is a new release, 1.x:

https://py-trees.readthedocs.io/en/release-1.0.x/index.html

However, with the latest py_trees release, several namings have changed, for example SUCCESS_ON_ONE became SuccessOnOne. We should update to the latest py_trees release and adapt our namings.

@fabianoboril
Copy link
Collaborator Author

The changelog can be found here:
https://py-trees.readthedocs.io/en/release-1.0.x/changelog.html#changelog

Changes that are problematic for us:
SUCCESS_ON_ONE --> SuccessOnOne()
SUCCESS_ON_ALL --> SuccessOnAll()
No more Python2 support

@fabianoboril
Copy link
Collaborator Author

See also PR #26

@germanros1987
Copy link
Member

Is our update intended to benefit from these new features?:

[composites] new parallel policies, SuccessOnAll, SuccessOnSelected
[decorators] oneshot policies for activating on completion or successful completion only

What is the good stuff of 1.0 that is making us update?

@fabianoboril
Copy link
Collaborator Author

The new parallel policies may be useful. At the same time, you could mimic this behavior also with py_trees 0.8.

@julienlau
Copy link

julienlau commented Oct 8, 2021

FYI
Please find below a poetry configuration that seems to work on ubuntu20.04:

[jlu@linux-gp75]> cat ~/carla-test/pyproject.toml
[tool.poetry]
name = "carla-test"
version = "0.0.1"
description = "test carla"

[tool.poetry.dependencies]
python = ">=3.7,<3.8"
xmlschema = "^1.8.0"
numpy = "^1.21.2"
six = "^1.16.0"
#py-trees = "^2.1.6"
py-trees = "<0.9"
ephem = "^4.1"
networkx = "^2.6.3"
Shapely = "^1.7.1"
tabulate = "^0.8.9"

[tool.poetry.dev-dependencies]

[build-system]
requires = ["poetry-core>=1.0.0"]
build-backend = "poetry.core.masonry.api"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants