Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend and enable support of OSC 1.0 example scenarios #545

Open
3 of 16 tasks
fabianoboril opened this issue May 26, 2020 · 7 comments
Open
3 of 16 tasks

Extend and enable support of OSC 1.0 example scenarios #545

fabianoboril opened this issue May 26, 2020 · 7 comments

Comments

@fabianoboril
Copy link
Collaborator

fabianoboril commented May 26, 2020

The OSC 1.0 release comes with several example scenarios, of which some work (partially), others do not work at all.

@qreezy
Copy link

qreezy commented May 26, 2020

EndOfTrafficJam:
Here the path to XODR is placed in a ParameterDeclaration:

<ParameterDeclaration name="$Road_Logics" parameterType="string" value="Databases/AB_RQ31_Crest.xodr"/>
...
<LogicFile filepath="$Road_Logics"/>

Therefore, the following fails (in openscenario_configuration, _set_carla_town):
if self.town is not None and ".xodr" in self.town:
as self.town is "$Road_Logics"

EDIT: Similar for "SlowPrecedingVehicle"

@qreezy
Copy link

qreezy commented May 26, 2020

EndOfTrafficJamNeighboringLaneOccupied:
Here, first the following fails in openscenario_parser, convert_position_to_transform:

if dlane == 0:
    wp = relative_waypoint
elif dlane == -1:
    wp = relative_waypoint.get_left_lane()
elif dlane == 1:
    wp = relative_waypoint.get_right_lane()
if wp is None:
    raise AttributeError("Object '{}' position with dLane={} is not valid".format(obj, dlane))

because wp will not be defined if dlane is neither of -1;0;1.
Once this is fixed, the proper
AttributeError: Object 'Ego' position with dLane=2.0 is not valid
gets thrown, which is due to the fact that changes over more than one lane are currently not supported.

@qreezy
Copy link

qreezy commented May 26, 2020

DoubleLaneChanger/FastOvertakeWithReInitialization/Overtaker/TrafficJam:
CARLA hard-crashes trying to load SampleDatabase.xodr

@qreezy
Copy link

qreezy commented May 26, 2020

SynchronizedArrivalToIntersection:
Relative paths to Vehicle/RouteCatalog not supported

@fabianoboril
Copy link
Collaborator Author

EndOfTrafficJam:
Here the path to XODR is placed in a ParameterDeclaration:

<ParameterDeclaration name="$Road_Logics" parameterType="string" value="Databases/AB_RQ31_Crest.xodr"/>
...
<LogicFile filepath="$Road_Logics"/>

Therefore, the following fails (in openscenario_configuration, _set_carla_town):
if self.town is not None and ".xodr" in self.town:
as self.town is "$Road_Logics"

EDIT: Similar for "SlowPrecedingVehicle"

This should be resolved with PR #543

@fabianoboril
Copy link
Collaborator Author

DoubleLaneChanger/FastOvertakeWithReInitialization/Overtaker/TrafficJam:
CARLA hard-crashes trying to load SampleDatabase.xodr

Let me forward this to the CARLA guys who work on the map stuff...

@fabianoboril
Copy link
Collaborator Author

@qreezy The crash of CARLA when loading certain maps should be resolved with the bug-fix release 0.9.9.4.

@fabianoboril fabianoboril added this to the OpenSCENARIO 1.0 milestone Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants