From 1788fe1fffa32969f1471a863c41018d1604403a Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Thu, 9 Apr 2020 14:15:47 +0200 Subject: [PATCH 1/3] packages/cli: remove notice plugin from eslint config --- packages/cli/config/eslint.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cli/config/eslint.js b/packages/cli/config/eslint.js index dbdb34927452a..c169e354d3380 100644 --- a/packages/cli/config/eslint.js +++ b/packages/cli/config/eslint.js @@ -26,7 +26,7 @@ module.exports = { 'plugin:monorepo/recommended', ], parser: '@typescript-eslint/parser', - plugins: ['notice', 'import'], + plugins: ['import'], env: { jest: true, }, From e6b0df8c1f94a846b2ca5fee9cc1560cf6aeda29 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Thu, 9 Apr 2020 14:17:06 +0200 Subject: [PATCH 2/3] packages/cli: add root eslintrc for app template --- packages/cli/templates/default-app/.eslintrc.js | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 packages/cli/templates/default-app/.eslintrc.js diff --git a/packages/cli/templates/default-app/.eslintrc.js b/packages/cli/templates/default-app/.eslintrc.js new file mode 100644 index 0000000000000..dd47f29781bad --- /dev/null +++ b/packages/cli/templates/default-app/.eslintrc.js @@ -0,0 +1,3 @@ +module.exports = { + extends: [require.resolve('@backstage/cli/config/eslint.js')], +}; From e55cdf70fd06297cdc76c74128c40d812bdbbadb Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Thu, 9 Apr 2020 14:21:47 +0200 Subject: [PATCH 3/3] packages/cli: add missing theme dep to app template --- packages/cli/templates/default-app/packages/app/package.json.hbs | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/cli/templates/default-app/packages/app/package.json.hbs b/packages/cli/templates/default-app/packages/app/package.json.hbs index fd0a19fed0ea8..6f24814a719ff 100644 --- a/packages/cli/templates/default-app/packages/app/package.json.hbs +++ b/packages/cli/templates/default-app/packages/app/package.json.hbs @@ -7,6 +7,7 @@ "@material-ui/icons": "^4.9.1", "@backstage/cli": "^{{version}}", "@backstage/core": "^{{version}}", + "@backstage/theme": "^{{version}}", "@testing-library/jest-dom": "^4.2.4", "@testing-library/react": "^9.3.2", "@testing-library/user-event": "^7.1.2",