Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark title displaying instead of tags #27

Open
isaaclo123 opened this issue Dec 31, 2018 · 3 comments
Open

Bookmark title displaying instead of tags #27

isaaclo123 opened this issue Dec 31, 2018 · 3 comments

Comments

@isaaclo123
Copy link
Contributor

It seems that because buku 4.0 adds a new "title" line to its output, the buku_run script is reading the wrong line for tags, and is displaying the title in place of tags in the menu.

buku-tag-issue

@plum
Copy link

plum commented Jan 24, 2019

Yes there is a problem of this sort. In fact problem occurs when editing. Instead of tags, the the URl is displayed, and the title is displayed instead of URL; upon exiting the edit URL dialogue the warning 'NOt a valid url ...' is displayed because it is in fact not aa url, but the title.
The title displays "waiting for input" - it is not being read.

So at this time the script doesnt work, except to launch a url ( in elinks in my case, not the xdg default).

I htinkit would be a brilliant boon if it worked again - the two buku and buku_run go so well together.

isaaclo123 added a commit to isaaclo123/buku_run that referenced this issue Apr 23, 2019
* tag parsing changed to search for tag in last line. This fixes buku
showing a url summary in the 3rd line.
@isaaclo123
Copy link
Contributor Author

@plum I made a fork that shows the bookmark tag correctly. It seems that GandaG already made a pull request for it but I didn't see it. :P I think mine may be a little more up to date with the master, so feel free to try this fork out; or just use GandaG's fork in #24.

@plum
Copy link

plum commented Apr 24, 2019

Thanks I shall try that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants