Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul link fixing #38

Open
zkamvar opened this issue May 26, 2021 · 0 comments
Open

Overhaul link fixing #38

zkamvar opened this issue May 26, 2021 · 0 comments

Comments

@zkamvar
Copy link
Contributor

zkamvar commented May 26, 2021

Since I have a much better abstraction for creating arbitrary XML to add into the document, my solution for reference link tags with missing references (aka klink, the links that were imported from a separate file) is a bit outdated and could stand to be defragged.

There are also a couple of issues that I need to tackle:

  1. ampersands need to be protected when creating links in xml_new_paragraph() (related to Clean newly created anchor links ropensci/tinkr#51). This is especially problematic when authors forget to escape ampersands.
  2. I need to think about how we post-process liquid links from reference-style links. They might be fine, but I need to make sure they can be fixed in post.
zkamvar added a commit that referenced this issue Jul 20, 2021
This partially addresses #38
zkamvar added a commit that referenced this issue Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant