Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of remote_theme #229

Closed
rgaiacs opened this issue Apr 18, 2018 · 7 comments
Closed

Use of remote_theme #229

rgaiacs opened this issue Apr 18, 2018 · 7 comments
Labels
type:enhancement Propose enhancement to the lesson

Comments

@rgaiacs
Copy link
Contributor

rgaiacs commented Apr 18, 2018

@dpshelio asked to prototype using https://blog.github.com/2017-11-29-use-any-theme-with-github-pages/ to "simplify" the building process.

@dpshelio
Copy link
Contributor

In my free time -- which is scarce -- I'm looking into that. I'll add here any updates.

@dpshelio
Copy link
Contributor

All right! it's done and it's super nice!!!

So, I've replicated swcarpentry organisation in a different github-org, and it works! Check the following

I think on the way I've also got two fixes!!!

I've also removed all the bin directory for this example. I would say that the bin directory could be provided to the lessons maintainers as a git-submodule in the same fashion that astropy does with their astropy-helpers. Keeping it on the same line, we could call it carpentries-helpers.

@rgaiacs
Copy link
Contributor Author

rgaiacs commented Apr 30, 2018

@dpshelio Thanks very much.

@fmichonneau Could you add this to be discussed on the 23 May meeting?

@klieret
Copy link
Contributor

klieret commented Jul 19, 2021

Hi @dpshelio @rgaiacs @fmichonneau . I'm curious about this change. Was there any specific reason you decided against this? This seems to be a very elegant solution for sharing common parts of code between the different repositories.

I'm part of an organization (HSF Training) that develops training modules based on your template (thank you! ❤️) for the high energy physics community and we have been recently discussing this exact change (here), because the number of our repositories continues to increase.

We'd be very happy to hear about your 2021 opinion on this :)

@maxim-belkin
Copy link
Contributor

@klieret, check out carpentries/carpentries-theme repo

@klieret
Copy link
Contributor

klieret commented Aug 9, 2021

Thanks a lot @maxim-belkin Exactly what we were looking for! I'm just curious that both styles and carpentries-theme currently coexist (and seem to be maintained somewhat separately). Why don't you simply remove all style files form styles and instead add carpentries-theme to its Gemfile?

@fmichonneau
Copy link
Contributor

Hi @klieret

We have both because we have many lessons that use and rely on styles, and the remote theme doesn't allow us to have other scripts our infrastructure needs (e.g., scripts run by make lesson-check).

All the commits in styles that affect the remote theme are synchronized regularly.

As a side-note, we are working on the next iteration of our lesson template which is designed to better compartmentalize styling, building, and checking.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Propose enhancement to the lesson
Projects
None yet
Development

No branches or pull requests

5 participants