Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All episodes in one page doesn't show figures #309

Closed
rgaiacs opened this issue Jun 22, 2018 · 3 comments
Closed

All episodes in one page doesn't show figures #309

rgaiacs opened this issue Jun 22, 2018 · 3 comments
Assignees
Labels
type:bug Code included in the lesson needs to be fixed
Milestone

Comments

@rgaiacs
Copy link
Contributor

rgaiacs commented Jun 22, 2018

This was reported by Cameron Macdonell.

http://carpentries.github.io/lesson-example/aio.html doesn't show the images because the path to images is wrong.

http://carpentries.github.io/lesson-example/aio.html will have

<img src="../fig/file-mapping.svg" alt="Source and Destination Files">

that will be resolved to http://carpentries.github.io/fig/file-mapping.svg when it should be resolved to http://carpentries.github.io/lesson-example/fig/file-mapping.svg.

Why this is happening

URL for each episode is like http://carpentries.github.io/lesson-example/XX-title/index.html.

How to fix this

Change the URL from http://carpentries.github.io/lesson-example/aio.html to http://carpentries.github.io/lesson-example/aio/index.html.

  1. Add permalink: aio/index.html to YAML header.
  2. Add root: .. to YAML header.
  3. Update https://github.com/carpentries/styles/blob/gh-pages/bin/lesson_check.py.
@rgaiacs rgaiacs added the type:bug Code included in the lesson needs to be fixed label Jun 22, 2018
@rgaiacs rgaiacs added this to the v9.6.0 milestone Jun 22, 2018
@rgaiacs rgaiacs self-assigned this Jun 22, 2018
@rgaiacs
Copy link
Contributor Author

rgaiacs commented Jun 22, 2018

carpentries/lesson-example#220 has one alternative solution to this one. It moves aio.md to _extras.

@rgaiacs
Copy link
Contributor Author

rgaiacs commented Dec 5, 2018

@maxim-belkin I believe this was fixed. Could you confirm? Thanks.

@fmichonneau
Copy link
Contributor

this has been addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Code included in the lesson needs to be fixed
Projects
None yet
Development

No branches or pull requests

2 participants