-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve make lesson-check
output
#611
Comments
I think this is a good suggestion. Would something like this work for you?
|
If the error messages are listed under each file/check, I think that would be okay. My preference is still with a "No errors found" message at the end if there are no issues. But, at least with the proposed output, a user would know it's doing something. Thanks! |
I've discovered several bugs in |
When I run
make lesson-check
there is no output- it just finishes running and presents a command prompt. I can only guess there are no errors in the lesson. To test this, I introduced errors. Sometimes it produced an error (when I deleted required files); sometimes not (when I introduced line-length errors).I recommend that
make lesson-check
always has output, including an explicit statement that the items checked in the lesson are without structural error. Perhaps include a list of what was checked.The text was updated successfully, but these errors were encountered: