Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about new menu item "FIXME" under "More" in the top navigation #45

Closed
emcaulay opened this issue Apr 25, 2023 · 5 comments
Closed
Labels
solution 💡 solution in comments solution in comments This issue has the solution in comments.

Comments

@emcaulay
Copy link

emcaulay commented Apr 25, 2023

I don't understand the "FIXME" menu option under the "More" menu for lessons that have been transitioned to Workbench. I see this in my lesson (lc-git: https://librarycarpentry.org/lc-git/reference.html) and also in another lesson I'm referring to (lc-spreadsheets: https://librarycarpentry.org/lc-spreadsheets/reference.html)

I'm pretty sure we didn't have that link in the Github versions, but I might be wrong.

Tagging, @carpentries/core-team-curriculum

@zkamvar
Copy link
Contributor

zkamvar commented Apr 25, 2023

Hi @emcaulay,

That is likely because the original version did not have a title (which was found to be a bug in the former template).

The solution is to edit that page and add change the title at the top from 'FIXME' to 'Reference'

@zkamvar
Copy link
Contributor

zkamvar commented Apr 25, 2023

Both of these pages should be documents that contain reference information for learners, namely a glossary, but it could be other reference material.

@zkamvar zkamvar added the solution in comments This issue has the solution in comments. label Apr 26, 2023
@zkamvar
Copy link
Contributor

zkamvar commented Apr 26, 2023

Thank you again for bringing this up, @emcaulay. Because of your reporting, I was able to find and correct the bug in my transition script. Moving forward, lessons will have the correct title for the reference page.

Please let me know if you would like me to create a pull request to fix the reference tite.

@emcaulay
Copy link
Author

emcaulay commented Apr 26, 2023 via email

@zkamvar
Copy link
Contributor

zkamvar commented Jun 2, 2023

Hi @emcaulay, I will close this as I believe this issue has been fixed.

@zkamvar zkamvar closed this as completed Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution 💡 solution in comments solution in comments This issue has the solution in comments.
Projects
None yet
Development

No branches or pull requests

2 participants