Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule for forcing defaultValue #126

Open
darky opened this issue Jan 16, 2024 · 1 comment
Open

Rule for forcing defaultValue #126

darky opened this issue Jan 16, 2024 · 1 comment

Comments

@darky
Copy link

darky commented Jan 16, 2024

Some functions like firstValueFrom, lastValueFrom, first, last and maybe some other is unsafe from EmptyError
Need to have rule, that will force you to define defaultValue for functions like above ☝️
@JasonWeinzierl JasonWeinzierl mentioned this issue Nov 11, 2024
Merged
JasonWeinzierl added a commit to JasonWeinzierl/eslint-plugin-rxjs-x that referenced this issue Nov 16, 2024
@JasonWeinzierl
feat(no-ignored-default-value): new rule for enforcing defaultValue (#15
9bd896e 
)

Introduces a new rule that enforces `defaultValue` to be passed into
`firstValueFrom`, `lastValueFrom`, `first`, and `last`, in order to
prevent `EmptyError`.

Resolves upstream
cartant#126
@JasonWeinzierl
Copy link

I've implemented a rule no-ignored-default-value in the forked package eslint-plugin-rxjs-x. Would welcome any feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@darky @JasonWeinzierl