Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indexing new providers contracts #23

Open
7 tasks done
brunomenezes opened this issue Jan 9, 2024 · 2 comments · May be fixed by #24
Open
7 tasks done

Indexing new providers contracts #23

brunomenezes opened this issue Jan 9, 2024 · 2 comments · May be fixed by #24
Assignees
@brunomenezes
Labels
Type: Feature Add a new feature to the system

Comments

@brunomenezes
Copy link
Collaborator

brunomenezes commented Jan 9, 2024 •
edited
Loading

📄 Context

An original PR on Sunodo has an implementation for indexing new provider contracts. However, we have a lot of commonalities, and the API could index such contracts.

✔️ Solution

Add the implementation of said contracts for indexing (use original PR as a reference). Also, consider the entity diagram below for implementation.

Entity diagram

image

New contracts (ABI) and events of interest:

  • AuthorityFactory
    • AuthorityCreated (topic)
  • ValidatorNodeProvider
    • MachineLocation (topic)
    • FinancialRunway (topic)
    • Paused (topic)
    • Unpaused (topic)
  • Marketplace
    • ValidatorNodeProviderCreated (topic)

New Entities:

  • Authority
  • ValidatorNodeProvider
  • ValidatorNode

📈 Subtasks

  • Add new contract ABIs.
  • Add new Entities to graphQL schema.
  • Generate new migrations.
  • Add new handlers for topics of interest.
  • Add preloaders for Marketplace to store ValidatorNodeProvider addresses
  • Add test cases.

🎯 Definition of Done

  • Can successfully index the AuthorityFactory, Marketplace and ValidatorNodeProvider contract events.
@brunomenezes brunomenezes added Type: Feature Add a new feature to the system Status: Discussion Collaboratively refine some idea / feature labels Jan 9, 2024
@brunomenezes brunomenezes self-assigned this Jan 9, 2024
@github-project-automation github-project-automation bot moved this to 📌 Todo in Explorer Unit Jan 9, 2024
@brunomenezes
Copy link
Collaborator Author

@tuler,
In the original PR, I saw the definition of the ReaderNodeProvider and ReaderNode entities. However, I could not see an ABI nor any reference to saving during the implementation in the main.ts when working with the block/log. Is that some initial idea forgotten to clean up, or is it missing?

@brunomenezes brunomenezes added Status: Refining Definition of the issue content is in-progress and removed Status: Discussion Collaboratively refine some idea / feature labels Jan 9, 2024
@tuler
Copy link
Member

tuler commented Jan 9, 2024

Maybe it's missing. I'm not implementing reader node just yet. Focusing on validator nodes only.

@brunomenezes brunomenezes removed the Status: Refining Definition of the issue content is in-progress label Jan 11, 2024
@brunomenezes brunomenezes moved this from 📌 Todo to 🧑‍💻 In Progress in Explorer Unit Jan 16, 2024
@brunomenezes brunomenezes linked a pull request Jan 23, 2024 that will close this issue
Feature: Indexing new contracts #24
Open
@brunomenezes brunomenezes linked a pull request Jan 29, 2024 that will close this issue
Open
@brunomenezes brunomenezes moved this from 🧑‍💻 In Progress to ✋ On-Hold in Explorer Unit Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brunomenezes brunomenezes

Labels
Type: Feature Add a new feature to the system
Projects
Explorer Unit
Status: ✋ On-Hold
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature: Indexing new contracts cartesi/rollups-explorer-api
2 participants
@tuler @brunomenezes