Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC-20 - Fix unnecessary network calls and UI loading-states. #279

Open
5 tasks
brunomenezes opened this issue Dec 13, 2024 · 0 comments
Open
5 tasks

ERC-20 - Fix unnecessary network calls and UI loading-states. #279

brunomenezes opened this issue Dec 13, 2024 · 0 comments
Labels
Type: Enhancement Improve an existing feature / design

Comments

@brunomenezes
Copy link
Collaborator

📄 Context

When using the send transaction feature in the ERC-20 form, when switching between the rollups version, the deposit button displays its loading state when the amount is zero.

PS: That is just a cosmetic improvement as you actually can't proceed with the deposit as 0 is an invalid amount

✔️ Solution

Given the parameters, a prepare statement goes into the network to check if the current transaction will be successful. The assumption is that the problem lies there; having a non-nil-undefined at the moment may be enough to enable that query. So the goal is to fix that condition and only allow that for amounts larger than 0( e.g. 0.1, 0.001,etc)

📈 Subtasks

  • Investigate and apply the fix to avoid unnecessary network calls.
  • Add test cases.

🎯 Definition of Done

  • Invalid amounts will not trigger perceived network calls in the UI (i.e. Deposit loading state displaying)
  • CI tests are passing.
  • Vercel builds are passing.
@brunomenezes brunomenezes added the Type: Enhancement Improve an existing feature / design label Dec 13, 2024
@github-project-automation github-project-automation bot moved this to 📌 Todo in Explorer Unit Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improve an existing feature / design
Projects
Status: 📌 Todo
Development

No branches or pull requests

1 participant