You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using the send transaction feature in the ERC-20 form, when switching between the rollups version, the deposit button displays its loading state when the amount is zero.
PS: That is just a cosmetic improvement as you actually can't proceed with the deposit as 0 is an invalid amount
✔️ Solution
Given the parameters, a prepare statement goes into the network to check if the current transaction will be successful. The assumption is that the problem lies there; having a non-nil-undefined at the moment may be enough to enable that query. So the goal is to fix that condition and only allow that for amounts larger than 0( e.g. 0.1, 0.001,etc)
📈 Subtasks
Investigate and apply the fix to avoid unnecessary network calls.
Add test cases.
🎯 Definition of Done
Invalid amounts will not trigger perceived network calls in the UI (i.e. Deposit loading state displaying)
CI tests are passing.
Vercel builds are passing.
The text was updated successfully, but these errors were encountered:
📄 Context
When using the send transaction feature in the ERC-20 form, when switching between the rollups version, the deposit button displays its loading state when the amount is zero.
PS: That is just a cosmetic improvement as you actually can't proceed with the deposit as 0 is an invalid amount
✔️ Solution
Given the parameters, a
prepare
statement goes into the network to check if the current transaction will be successful. The assumption is that the problem lies there; having a non-nil-undefined at the moment may be enough to enable that query. So the goal is to fix that condition and only allow that for amounts larger than 0( e.g. 0.1, 0.001,etc)📈 Subtasks
🎯 Definition of Done
The text was updated successfully, but these errors were encountered: