Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ether deposit - Improve error message checks #280

Closed
6 tasks done
brunomenezes opened this issue Dec 13, 2024 · 0 comments · Fixed by #285
Closed
6 tasks done

Ether deposit - Improve error message checks #280

brunomenezes opened this issue Dec 13, 2024 · 0 comments · Fixed by #285
Assignees
Labels
Type: Enhancement Improve an existing feature / design

Comments

@brunomenezes
Copy link
Collaborator

brunomenezes commented Dec 13, 2024

📄 Context

When using the deposits through the Ether portal, the validation for the amount exceeding the balance takes a long time as it is waiting for a prepare call to resume. Instead, retrieving the balance information from the wallet connected and adding this new validation as the user fills the form would be faster and more efficient.

✔️ Solution

Get the current ETH balance of the connected account and include it in the validation for the amount the user defines rather than wait for the return of the prepare checks.

wording: The amount ${amount} exceeds your current balance of ${balance} ETH

📈 Subtasks

  • Add the new validation for faster local validation in terms of an amount exceeding the balance.
  • Add test cases.

🎯 Definition of Done

  • As I try to add an amount bigger than my balance, I can quickly see the error message.
  • An invalid form will not allow the user to proceed with the deposit.
  • CI checks are passing.
  • Vercel preview builds are passing.
@brunomenezes brunomenezes added the Type: Enhancement Improve an existing feature / design label Dec 13, 2024
@github-project-automation github-project-automation bot moved this to 📌 Todo in Explorer Unit Dec 13, 2024
@nevendyulgerov nevendyulgerov self-assigned this Dec 16, 2024
@nevendyulgerov nevendyulgerov moved this from 📌 Todo to 🧑‍💻 In Progress in Explorer Unit Jan 2, 2025
@nevendyulgerov nevendyulgerov linked a pull request Jan 2, 2025 that will close this issue
@nevendyulgerov nevendyulgerov moved this from 🧑‍💻 In Progress to 👁 In Review in Explorer Unit Jan 2, 2025
@github-project-automation github-project-automation bot moved this from 👁 In Review to 📦 Done in Explorer Unit Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improve an existing feature / design
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants