#281 Fix url search query params #282
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he url search params
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -12,35 +11,38 @@ export const limitBounds = { | |||
| export type LimitBound = (typeof limitBounds)[keyof typeof limitBounds]; | |||
|
|
|||
| export type UsePaginationReturn = [ | |||
There was a problem hiding this comment.
I think you forgot to rename the Interface to also match the new hook's name
cc: @nevendyulgerov
| updateQueryParams(keyword); | ||
| onChange(keyword); | ||
| }, [query, onChange, keyword, updateQueryParams]); | ||
| if (lastSearch.current !== query) { |
There was a problem hiding this comment.
I wonder if that useEffect is necessary and if the logic ever runs because of how the onSearch callback is defined below. I believe the effect is fired as expected, but I guess that if is never evaluated to true.
cc: @nevendyulgerov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I deprecated the custom hooks
useQueryParamsandusePaginationParamsand unified their logic into a new custom hook -useUrlSearchParamswhere all three params (page,limit,query) are being handled.