Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streaming calls do not time out #28

Open
gaschler opened this issue Aug 7, 2018 · 1 comment
Open

Streaming calls do not time out #28

gaschler opened this issue Aug 7, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@gaschler
Copy link
Contributor

gaschler commented Aug 7, 2018

Clients should always set a deadline: https://grpc.io/blog/deadlines
Client should support setting a timeout and provide a default.
Currently, Client::Write blocks without a time limit (for instance if the server address is wrong).
@gaschler gaschler added the bug Something isn't working label Aug 7, 2018
@gaschler
Copy link
Contributor Author

gaschler commented Aug 9, 2018

With #31, unary calls now offer a timeout (without default). Renaming the issue.

Unfortunately, for streaming rpc, set_deadline is valid for the entire stream, so implementing a timeout that is holds for each Write will require a large work-around.

@gaschler gaschler changed the title Calls do not time out Streaming calls do not time out Aug 9, 2018
ambroff pushed a commit to ambroff/async_flatbuffer_grpc that referenced this issue Oct 15, 2019
@gaschler
Unary client supports timeout (cartographer-project#31)
771af45 
ISSUE=cartographer-project#28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gaschler