Skip to content

All key commands don't work #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thomas-schiwietz-ai opened this issue Jan 7, 2019 · 4 comments
Closed

All key commands don't work #186

thomas-schiwietz-ai opened this issue Jan 7, 2019 · 4 comments

Comments

@thomas-schiwietz-ai
Copy link

thomas-schiwietz-ai commented Jan 7, 2019

None of the key commands work anymore.

keymod is always false:
https://github.com/googlecartographer/point_cloud_viewer/blob/master/sdl_viewer/src/lib.rs#L439

related to Rust-SDL2/rust-sdl2#580?

@SirVer
Copy link
Contributor

SirVer commented Jan 7, 2019

cannot repro on latest master with latest rust stable.

@DarthBubi
Copy link

DarthBubi commented Mar 20, 2019

This seems to be related to an active num lock or caps lock. In this statement keymod is only checked for an empty value, which is not the case, if num lock is active. A work around would be to change
if keymod.is_empty() to
if keymod.is_empty() || keymod.intersects(NUMMOD | CAPSMOD) && !keymod.intersects(LCTRLMOD | RCTRLMOD)
The last check prevents the following else ifs from breaking.
Alternatively one could tell the user to disable num lock etc. on the keyboard, which seems inconvenient.

@codeislife99
Copy link

Please fix this issue. Its very annoying and very non-intuitive.

@feuerste
Copy link

feuerste commented Jul 4, 2019

#287 already fixed the NUMMOD issue. If you think that navigationg with CAPSMOD is required, too, please reopen this issue.

@feuerste feuerste closed this as completed Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants