You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
what is optional or not? The default value is None for all fields, but the type indicated in the docstring is not optional for the data field.
data: DataFrame
A single dataframe that contains columns represeting all other
arguments to the Triangle constructor
How do origin and development behave when passed in as lists?
origin: str or list
A representation of the accident, reporting or more generally the
origin period of the triangle that will map to the Origin dimension
development: str or list
A representation of the development/valuation periods of the triangle
that will map to the Development dimension
development is optional or not?: The docstring says str or list but there are tests that do not pass it in, is it optional?
The text was updated successfully, but these errors were encountered:
Problem
I have a hard time understanding the exact supported usage patterns for the Triangle constructor based on the source code + docstring.
Proposed solution
Make it clear in the source code what valid ways to construct a Triangle are. Pandas includes examples in their docstring: https://github.com/pandas-dev/pandas/blob/v2.1.4/pandas/core/frame.py#L541
Things that confuse me
what is optional or not? The default value is None for all fields, but the type indicated in the docstring is not optional for the data field.
How do origin and development behave when passed in as lists?
development is optional or not?: The docstring says
str or list
but there are tests that do not pass it in, is it optional?The text was updated successfully, but these errors were encountered: