Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Suggestion: Alternative parameter name for format argument in _to_datetime method #526

Open
genedan opened this issue May 27, 2024 · 0 comments
Assignees

Comments

@genedan
Copy link
Contributor

genedan commented May 27, 2024

In the TriangleBase class there is a method called _to_datetime that has an argument called format:

@staticmethod
def _to_datetime(data, fields, period_end=False, format=None):

I'm getting a warning from my IDE that format shadows a built-in name in Python. I propose that we rename it to something else, maybe datetime_format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants