sklearn update to _fit_single_estimator

[ohsosunny]

chainladder-python/chainladder/workflow/voting.py

Line 127 in 7e5dd10

sample_weight=sample_weight,

sklearn update in https://github.com/scikit-learn/scikit-learn/blob/7398114752a056edffb6c768393e61c32d56a6c6/sklearn/ensemble/_base.py#L21C22-L21C32 no longer has sample_weight as parameter. It needs fit_params instead.

[kennethshsu]

Hi @ohsosunny, are you proposing that we change the name of the variable from sample_weight to fit_params? Do you think sample_weight is an inappropriate use in the package? Why?

[ohsosunny]

Oh! Yes, the commit in scikit-learn/scikit-learn@77a63e7 for sklearn _fit_single_estimator updated sample_weight with fit_params. chainladder-python/chainladder/workflow/voting.py needs to pass in fit_params

[Vu1992]

Hello, i think we need the voting chain to work as sklearn has changed sample_weight to fit_params

[jbogaardt]

Resolved in chainladder==0.8.24